Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have opentsdb.Duration implement encoding.TextUnmarshaler. #1975

Merged
merged 1 commit into from
Dec 1, 2016

Conversation

alienth
Copy link
Contributor

@alienth alienth commented Nov 30, 2016

👓 @captncraig @kylebrandt

Will be using this to read durations from a config file on a separate utility.

@captncraig
Copy link
Contributor

Lgtm

@kylebrandt
Copy link
Member

kylebrandt commented Dec 1, 2016 via email

@alienth
Copy link
Contributor Author

alienth commented Dec 1, 2016

Not sure if I'll be around during your morning time. Mind prodding at this via comments?

For further context, this is so I can json/toml unmarshal a file straight into a struct containing an opentsdb.Duration field.

@kylebrandt
Copy link
Member

kylebrandt commented Dec 1, 2016 via email

@alienth
Copy link
Contributor Author

alienth commented Dec 1, 2016

Gotcha, works for me. Thanks!

@kylebrandt kylebrandt merged commit e969726 into bosun-monitor:master Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants