Stop sending mail if 'To' slice empty #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradeepbbl
force-pushed
the
fix_bad_email
branch
from
6ff2a17 to
f65e956
Compare
clinta
pushed a commit
to clinta/bosun
that referenced
this pull request
Mar 9, 2018
pradeepbbl
added a commit
to pradeepbbl/bosun
that referenced
this pull request
Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed when a post action notification triggered bosun also trying to send mail with empty 'To' address
2018/02/05 12:15:30 error: notify.go:49: sending email: Must specify at least one From address and one To address2018/02/05 12:17:30 error: notify.go:205: failed to send alert to [] Must specify at least one From address and one To addressThis patch will validate the 'To' address slice length and stop trying sending mail if it's empty
Thanks,