cmd/scollector: (wip) windows remote access services (ras) metrics #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebrandt
commented
Apr 25, 2018
| } | ||
| // If RaMgmtSvc and has at least one entry - we monitor it | ||
| // TODO: Follow init / Enable, see if it is okay to scope `dst` this way | ||
| c.Enable = func() bool { return err == nil && len(dst) > 0 } |
There was a problem hiding this comment.
@captncraig you know how this works? Should the lines above be inside the c.Enable func?
There was a problem hiding this comment.
I believe the enable fun runs periodically on the host. So if you want to have it continually check if those counters are avilible, yes, put all the above code into the func. If you want to check once on scollector startup, then don't use the Enable func, just don't insert the collector on line 28.
captncraig
approved these changes
Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.