Support additional versions in pyproject #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love to see this get merged as well. Any way we can help? |
SofienBenAyed
approved these changes
Jul 29, 2024
|
Thanks a lot and sorry for the delay! |
|
Sorry for the mistake last time. |
|
Thank you very much for your contribution (merged in #17 ) In the end, we chose to not pin a specific version in pyproject.toml, which means even if we're lagging a bit behind on Django versions, the project will still be usable. It was also a good opportunity to drop outdated python & django versions ! Overall, thanks again @tsingla1998 (& @violuke for the issue), and let us know if anything is still needed :) (and you're welcome to contribute again :D ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using this in a project that is using Django 4.2 with Poetry. Version resolution fails because it is expecting >= 2.2 <3 even though this project supports 4.2. This PR proposes a fix by allowing additional django versions to be supported with poetry.