Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max_bandwidth to TransferConfig #3059

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Add max_bandwidth to TransferConfig #3059

merged 1 commit into from
Oct 27, 2021

Conversation

nateprewitt
Copy link
Contributor

This PR should address #1430 by adding a max_bandwidth argument to Boto3's TransferConfig wrapper class. This will allow direct support for forwarding the parameter down to s3 with additional work arounds.

@nateprewitt nateprewitt mentioned this pull request Oct 26, 2021
Closed
@nateprewitt nateprewitt requested a review from kyleknap October 26, 2021 20:57
kyleknap
kyleknap reviewed Oct 27, 2021
View reviewed changes
Copy link
Contributor

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just had a small comment.

boto3/s3/transfer.py Show resolved Hide resolved
kyleknap
kyleknap approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚢

@nateprewitt nateprewitt merged commit c5487b5 into boto:develop Oct 27, 2021
@nateprewitt nateprewitt deleted the transfer_config branch October 27, 2021 01:37
aws-sdk-python-automation added a commit that referenced this pull request Oct 27, 2021
@aws-sdk-python-automation
Merge branch 'release-1.19.5'
527297d 
* release-1.19.5:
  Bumping version to 1.19.5
  Add changelog entries from botocore
  Add get_partition_for_region to Session (#3060)
  Add max_bandwidth to TransferConfig (#3059)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleknap kyleknap kyleknap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nateprewitt @kyleknap