Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example for ExposeHeaders #3251

Merged
merged 1 commit into from
May 2, 2022
Merged

Fix example for ExposeHeaders #3251

merged 1 commit into from
May 2, 2022

Conversation

simonw
Copy link
Contributor

@simonw simonw commented May 1, 2022

ExposeHeaders should be a list of HTTP header names, not a list of HTTP methods.

Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you @simonw!

@nateprewitt nateprewitt changed the base branch from master to develop May 1, 2022 19:37
@nateprewitt
Copy link
Contributor

It looks like this was made against the master branch rather than our primary develop branch. I tried to swap it but the merge isn’t clean. Would you mind rebasing your commit onto the tip of develop?

@nateprewitt nateprewitt changed the base branch from develop to master May 1, 2022 19:44
ExposeHeaders should be a list of HTTP header names, not a list of HTTP methods.
@nateprewitt nateprewitt changed the base branch from master to develop May 2, 2022 16:57
@nateprewitt
Copy link
Contributor

I went ahead and rebased the change onto develop. I'll close and re-open the build to trigger the correct GH action and then I think we're set to merge. Thanks again!

@nateprewitt nateprewitt closed this May 2, 2022
@nateprewitt nateprewitt reopened this May 2, 2022
@nateprewitt nateprewitt merged commit abc9598 into boto:develop May 2, 2022
aws-sdk-python-automation added a commit that referenced this pull request May 3, 2022
* release-1.22.6:
  Bumping version to 1.22.6
  Add changelog entries from botocore
  Fix example for ExposeHeaders (#3251)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants