Add version floor for transfer feature #3957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleknap
reviewed
Nov 29, 2023
| assert has_minimum_crt_version((0, 16, 12)) is True | ||
|
|
||
| @requires_crt() | ||
| def test_minimum_crt_version_bad_crt_version(self): |
There was a problem hiding this comment.
It might be worth parameterizing this to test out other edge cases that could cause issues. Off the top of my head, we could add cases when __version__:
- Is a value that can't be converted to an
int(). Like if there are are beta or alpha identifiers. - The value does not follow the pattern of
x.y.z(e.g.0.20)
There was a problem hiding this comment.
0.20 should actually still work with tuple comparison. I can add a 0.0.0-dev or something though for the first case.
There was a problem hiding this comment.
We can also fast follow on making these test updates. Does not need to block getting this released
kyleknap
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set a version floor for the CRT transfer feature for cases where customers may be deployed on a platform with an outdated version of
awscrt.