Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client exceptions to boto3 docs #4343

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

alexgromero
Copy link
Contributor

@alexgromero alexgromero commented Nov 12, 2024

This PR adds the Client Exceptions section to the boto3 client docs to match botocore's documentation.

Generated docs:
Screenshot 2024-11-12 at 11 22 35 AM

abort_multipart_upload example:
Screenshot 2024-11-12 at 11 22 54 AM

@SamRemis
Copy link
Contributor

Looks good to me - I'm not sure if the second example screenshot is relevant; it seems to me that section already exists, and the section we are adding is for the client pages, not the operation pages. Is that correct?

@alexgromero
Copy link
Contributor Author

alexgromero commented Nov 19, 2024

@SamRemis, correct and you're right that the section already existed, but now you're able to click into the linked exception to view it which is why I added the screenshot.

This is what it looks like currently:
Screenshot 2024-11-19 at 4 01 59 PM

@alexgromero alexgromero merged commit 65db73f into boto:develop Nov 20, 2024
39 checks passed
@alexgromero alexgromero deleted the docs-client-exceptions branch November 20, 2024 15:57
aws-sdk-python-automation added a commit that referenced this pull request Nov 20, 2024
* release-1.35.66:
  Bumping version to 1.35.66
  Add changelog entries from botocore
  Add client exceptions to boto3 docs (#4343)
hswong3i pushed a commit to alvistack/boto-boto3 that referenced this pull request Nov 21, 2024
nateprewitt added a commit that referenced this pull request Nov 22, 2024
aws-sdk-python-automation added a commit that referenced this pull request Nov 22, 2024
* release-1.35.67:
  Bumping version to 1.35.67
  Add changelog entries from botocore
  Revert "Add client exceptions to boto3 docs (#4343)"
hswong3i pushed a commit to alvistack/boto-boto3 that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants