Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite loop when BOTO_DATA_PATH is used #5

Closed
a13m opened this issue Jan 3, 2013 · 2 comments
Closed

Infinite loop when BOTO_DATA_PATH is used #5

a13m opened this issue Jan 3, 2013 · 2 comments

Comments

@a13m
Copy link

a13m commented Jan 3, 2013

I attempted to set BOTO_DATA_PATH to experiment with a non-AWS provider, and this code goes into an infinite loop on my system:

135 paths = os.environ['BOTO_DATA_PATH'].split(':')
136 for path in paths:
137 path = os.path.expandvars(path)
138 path = os.path.expanduser(path)
139 paths.append(path)

the loop append to "paths" whether or not expandvars and expanduser result in a different path.
@garnaat
Copy link
Member

garnaat commented Jan 3, 2013

Hi Andy -

I believe this has already been fixed in the develop branch. A new release will be coming later today. Thanks!

@garnaat
Copy link
Member

garnaat commented Jan 4, 2013

This should be fixed in the 0.4.2 release and in the develop branch. Please re-open if you are still having problems.

@garnaat garnaat closed this as completed Jan 4, 2013
stealthycoin pushed a commit to stealthycoin/botocore that referenced this issue Dec 1, 2016
# This is a combination of 6 commits.
1eba0c9 
# This is the 1st commit message:
# This is a combination of 6 commits.
# This is the 1st commit message:
Add idempotency token autoinjection.

# The commit message boto#2 will be skipped:

#	Remove unused imports

# The commit message boto#3 will be skipped:

#	First draft of injecting idempotencyToken

# The commit message boto#4 will be skipped:

#	Register with the before-parameter-build event everywhere.

# The commit message boto#5 will be skipped:

#	Test injecting indepotency token and not replacing an existing one.

# The commit message boto#6 will be skipped:

#	Not sure how I managed to modify this.

# The commit message boto#7 will be skipped:

#	PEP8

# The commit message boto#8 will be skipped:

#	PEP8

# The commit message boto#9 will be skipped:

#	Ignore mock models from tests that do not care about the model.

# The commit message boto#10 will be skipped:

#	Remove test for members which will always be on input_shape

# The commit message boto#1 will be skipped:

#	Rewrite functional test as two functional tests

# The commit message boto#2 will be skipped:

#	Make the idempotency callback less specific/lower priority

# The commit message boto#3 will be skipped:

#	Change tests so the assert happens in the test fns instead of setup

# The commit message boto#4 will be skipped:

#	Fix tests to use MagicMock which handles iteration properly.

# The commit message boto#5 will be skipped:

#	Add better logger message

# The commit message boto#6 will be skipped:

#	Add a unit test for idempotent token injection

# The commit message boto#2 will be skipped:

#	Move idempotency check to the operation model

# The commit message boto#3 will be skipped:

#	Fix unit test to mock the new get_idempotent_members

# The commit message boto#4 will be skipped:

#	Change name and get rid of redundant property

# The commit message boto#5 will be skipped:

#	Added idempotency to the metadata

# The commit message boto#6 will be skipped:

#	Added test for a pre-provided idempotency key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garnaat @a13m