Fix handling of unflattened map parameters in query services. #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but I think it might be good to have a botocore specific unit test for this. |
|
Yeah, that's a good idea. I'll add that. |
jamesls
added a commit
to aws/aws-cli
that referenced
this pull request
Dec 6, 2013
* release-1.2.7: (21 commits) Bumping version to 1.2.7 Update changelog with the latest changes Change mututally to mutually Allow the --protocol option of ec2 create-network-acl-entry command to accept tcp|udp|icmp|all in addition to the numeric protocol numbers. The docs for the command already say it does this but the actual EC2 operation supports only integer values. Fix bug when filtering s3 locations Clean up existing filter unit tests Add unittest for website redirect location Add unit test for recursive download Remove extraneous log statements. Fix an assumption in argprocess.py that all map types will have an enum of possible keys. Also change the import of json to come from the botocore.compat module and also set the object_pairs_hook to use OrderedDict so unit tests can be compared properly. Dependent on boto/botocore#185. Fixes #407. Add tests that verify what ops were called Add a short circuit path for listing a specific s3 object Remove newline between task fail and error messages Add attributes to exception in errorhandler Remove src/dest resource existence check If --private-ip-address is specified with any other options that require the creation of a NetworkInterfaces structure, move the value of --private-ip-address into the NetworkInterfaces structure. Fixes #520. Log CLI/botocore version in the debug logs Add changelog entry for issue 516 Handle a list of strings from a dict in text output Remove tutorial in favor of user guide ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for aws/aws-cli#407.