Reintroduce #221

[jamesls]

Fixes aws/aws-cli#614.

The fix for botocore was good. Looking into this issue, the problem was that the accompanying CLI PR was encoding the copy source name to utf-8 when all of that logic is moved into botocore. This meant that was were utf-8 encoding the source twice, which is what was causing the test failures with unicode chars.

Also see: aws/aws-cli#688

[toastdriven]

Looks good.

[garnaat]

I ran both unit and integration tests for botocore and awscli (in conjunction with aws/aws-cli#688) as well as some ad hoc tests. All good.

However, when trying the ad hoc tests from #221 the:

aws s3 cp s3://bucketname/✓ s3://otherbucket/✓  # This fails with a key does not exist.

is still failing for me. Do you see that?

[jamesls]

Hmm, just doubled checked, and I'm not seeing that issue:

$ aws s3 cp s3://bucket/checkmark/✓  s3://bucket/checkmark/3/✓
copy: s3://bucket/checkmark/✓ to s3://bucket/checkmark/3/✓

$ aws s3 ls bucket/checkmark/3/
2014-03-05 10:18:56          0 ✓

[jamesls]

Ahh, I was using an empty file. Using something large enough to trigger multipart copies shows the issue. Looking...

[jamesls]

Too many things at once, I was using the develop branch when I ran the multipart copy test in my previous comment.

Using the proper branches of botocore/CLI, I can confirm I see no issues with unicode chars copies for both small/large files. Sorry for the noise.

[garnaat]

I must have the same problem. I just went through and made sure my botocore and awscli were on the right branch and installed properly and tried again and couldn't reproduce that copy error.

LGTM