Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not set_ciphers(DEFAULT_CIPHERS) if DEFAULT_CIPHERS is None #2924

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Do not set_ciphers(DEFAULT_CIPHERS) if DEFAULT_CIPHERS is None #2924

merged 1 commit into from
Apr 28, 2023

Conversation

graingert
Copy link
Contributor

Fixes #2921

@graingert graingert mentioned this pull request Apr 28, 2023
Merged
nateprewitt
nateprewitt approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @graingert!

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023 •
edited
Loading

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.01 ⚠️

Comparison is base (aa63a37) 93.42% compared to head (5ec04be) 93.41%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2924      +/-   ##
===========================================
- Coverage    93.42%   93.41%   -0.01%     
===========================================
  Files           63       63              
  Lines        13558    13561       +3     
===========================================
+ Hits         12666    12668       +2     
- Misses         892      893       +1
Impacted Files Coverage Δ
botocore/httpsession.py 92.01% <75.00%> (-0.30%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@graingert
Copy link
Contributor Author

This lowers coverage because you're not testing against urllib3 2 yet

@nateprewitt nateprewitt merged commit 7b4c26e into boto:develop Apr 28, 2023
aws-sdk-python-automation added a commit that referenced this pull request Apr 28, 2023
@aws-sdk-python-automation
Merge branch 'release-1.29.123'
44e2c76 
* release-1.29.123:
  Bumping version to 1.29.123
  Update to latest partitions and endpoints
  Update to latest models
  Do not set_ciphers(DEFAULT_CIPHERS) if DEFAULT_CIPHERS is None (#2924)
This was referenced May 3, 2023
Closed
Closed
@br3ndonland br3ndonland mentioned this pull request May 6, 2023
Closed
@nateprewitt nateprewitt mentioned this pull request May 17, 2023
Closed
@htlgit00 htlgit00 mentioned this pull request May 21, 2023
Open
@tim-finnigan tim-finnigan mentioned this pull request May 23, 2023
Closed
@tjni tjni mentioned this pull request Jun 29, 2023
Closed
@FredStober FredStober mentioned this pull request Nov 3, 2023
Closed
@yan12125 yan12125 mentioned this pull request Apr 9, 2024
Open
@nateprewitt nateprewitt mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nateprewitt nateprewitt nateprewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to import boto3 because of botocore dependancies on urllib3s removed DEFAULT_CIPHERS
3 participants
@graingert @codecov-commenter @nateprewitt