-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert SQS protocol changes #2931
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## develop #2931 +/- ##
===========================================
- Coverage 93.41% 93.38% -0.03%
===========================================
Files 63 63
Lines 13561 13561
===========================================
- Hits 12668 12664 -4
- Misses 893 897 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
* release-1.29.128: Bumping version to 1.29.128 Revert SQS protocol changes (#2931)
Hi @nateprewitt, I was just looking into fixing this for |
Hi @bblommers, this change will be rolled back out to production in the future. It's currently being reverted to help alleviate some issues with tools used in some Airflow workflows. It'll be best if anyone planning to support mocking tools move towards the JSON format seen in 1.29.127. I'll try to proactively provide more information on timeline as we have it available. |
Appreciate the info @nateprewitt - having a timeline/estimate would be very useful. Do you know if other XML-based services, like EC2 or S3, will get the same treatment? |
@bblommers I can't say anything definitively about the future. This change is currently only targeted for SQS which uses the I've passed up feedback internally to make sure we have a better rollout plan for these changes in the future though to help share information more proactively. |
Awesome, thanks @nateprewitt! |
Roll back recent SQS changes.