Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert SQS protocol changes #2931

Merged
merged 2 commits into from
May 5, 2023
Merged

Conversation

nateprewitt
Copy link
Contributor

Roll back recent SQS changes.

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (2395012) 93.41% compared to head (6071f92) 93.38%.

❗ Current head 6071f92 differs from pull request most recent head 054004d. Consider uploading reports for the commit 054004d to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2931      +/-   ##
===========================================
- Coverage    93.41%   93.38%   -0.03%     
===========================================
  Files           63       63              
  Lines        13561    13561              
===========================================
- Hits         12668    12664       -4     
- Misses         893      897       +4     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@nateprewitt nateprewitt merged commit 47676c3 into boto:develop May 5, 2023
@nateprewitt nateprewitt deleted the sqs_change branch May 5, 2023 16:46
aws-sdk-python-automation added a commit that referenced this pull request May 5, 2023
* release-1.29.128:
  Bumping version to 1.29.128
  Revert SQS protocol changes (#2931)
@bblommers
Copy link

Hi @nateprewitt, I was just looking into fixing this for Moto.
Will the JSON format be reintroduced at some point in the future, or is the SQS-service going to stick with XML for now?

@nateprewitt
Copy link
Contributor Author

Hi @bblommers, this change will be rolled back out to production in the future. It's currently being reverted to help alleviate some issues with tools used in some Airflow workflows. It'll be best if anyone planning to support mocking tools move towards the JSON format seen in 1.29.127.

I'll try to proactively provide more information on timeline as we have it available.

@bblommers
Copy link

Appreciate the info @nateprewitt - having a timeline/estimate would be very useful.

Do you know if other XML-based services, like EC2 or S3, will get the same treatment?

@nateprewitt
Copy link
Contributor Author

@bblommers I can't say anything definitively about the future. This change is currently only targeted for SQS which uses the query protocol (which is different than the XML formats used by s3/ec2).

I've passed up feedback internally to make sure we have a better rollout plan for these changes in the future though to help share information more proactively.

@bblommers
Copy link

Awesome, thanks @nateprewitt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants