Configured endpoint url resolver functional tests #2964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## configured-endpoint-urls #2964 +/- ##
=========================================================
Coverage 93.32% 93.32%
=========================================================
Files 64 64
Lines 13662 13662
=========================================================
Hits 12750 12750
Misses 912 912 ☔ View full report in Codecov by Sentry. |
kdaily
commented
Jun 8, 2023
kdaily
commented
Jun 8, 2023
kdaily
commented
Jun 8, 2023
nateprewitt
reviewed
Jun 12, 2023
kdaily
force-pushed
the
configured-endpoint-url-resolver-functional-tests
branch
2 times, most recently
from
abfd5fa
to
b7c529a
Compare
kdaily
force-pushed
the
configured-endpoint-url-resolver-functional-tests
branch
2 times, most recently
from
6b8dba5
to
d4e3f56
Compare
kyleknap
reviewed
Jun 16, 2023
tests/functional/data/configured-endpoint-urls/test-cases/profile-tests.json
Outdated
Show resolved
Hide resolved
kdaily
force-pushed
the
configured-endpoint-url-resolver-functional-tests
branch
3 times, most recently
from
f93f7f9
to
966998f
Compare
kyleknap
reviewed
Jun 19, 2023
tests/functional/data/configured-endpoint-urls/test-cases/profile-tests.json
Outdated
Show resolved
Hide resolved
tests/functional/data/configured-endpoint-urls/test-cases/profile-tests.json
Outdated
Show resolved
Hide resolved
kyleknap
reviewed
Jun 19, 2023
tests/functional/data/configured-endpoint-urls/test-cases/profile-tests.json
Outdated
Show resolved
Hide resolved
kyleknap
approved these changes
Jun 19, 2023
kdaily
force-pushed
the
configured-endpoint-url-resolver-functional-tests
branch
from
36a5f7a
to
60af11c
Compare
The tests use a data file to load tests that enumerate the ways that the endpoint URL can be defined and asserts that the correct endpoint is used in a request and that it is ignored correctly if the appropriate shared config file property or environment variable is supplied. They also assert that the correct config section name and environment variable name are used to configure and override the endpoint URL for every AWS service.
kdaily
force-pushed
the
configured-endpoint-url-resolver-functional-tests
branch
from
60af11c
to
d9a7dd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functional testing for use of a configured endpoint url through the shared config file and environment variables.
First, the tests use a data file to load tests that enumerate the combinatorial ways that the endpoint URL can be defined (shared configuration file and environment variable for individual service and global/all services), and asserts that the correct endpoint is returned.
The tests also assert that the correct config section name and environment variable name are used to configure and override the endpoint URL for all services.
Lastly, the tests check that a operations for a subset of services use the endpoint override in a request.