Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-Agent component customization #2996

Merged
merged 4 commits into from
Aug 10, 2023

Conversation

jonathan343
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (168fc39) 93.36% compared to head (b332aad) 93.39%.
Report is 9 commits behind head on develop.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2996      +/-   ##
===========================================
+ Coverage    93.36%   93.39%   +0.03%     
===========================================
  Files           66       66              
  Lines        13957    13963       +6     
===========================================
+ Hits         13031    13041      +10     
+ Misses         926      922       -4     
Files Changed Coverage Δ
botocore/useragent.py 95.13% <100.00%> (+0.93%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor notes, otherwise looks good!

botocore/useragent.py Show resolved Hide resolved
tests/unit/test_useragent.py Outdated Show resolved Hide resolved
Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @jonathan343!

@jonathan343 jonathan343 merged commit 722575d into boto:develop Aug 10, 2023
34 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Aug 10, 2023
* release-1.31.24:
  Bumping version to 1.31.24
  Update to latest partitions and endpoints
  Update to latest models
  User-Agent component customization (#2996)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants