Update event stream tests #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a pair of event stream tests. Implementations of `application/vnd.amazon.eventstream` are expected to check the CRC before attempting to semantically parse the prelude. The tests meant to enforce that were present, but the wrong error was being asserted. This change fixes the ordering of checks, fixes the tests, and adds two new test cases to make assertions about the error types that were previously being applied to the old tests.
JordonPhillips
force-pushed
the
touch-up-eventstream
branch
from
e07e150
to
823c76b
Compare
aws-sdk-python-automation
added a commit
that referenced
this pull request
Sep 12, 2024
* release-1.35.18: Bumping version to 1.35.18 Update to latest models Merge customizations for Glue Update event stream tests (#3254)
hswong3i
pushed a commit
to alvistack/boto-botocore
that referenced
this pull request
Sep 13, 2024
This fixes a pair of event stream tests. Implementations of `application/vnd.amazon.eventstream` are expected to check the CRC before attempting to semantically parse the prelude. The tests meant to enforce that were present, but the wrong error was being asserted. This change fixes the ordering of checks, fixes the tests, and adds two new test cases to make assertions about the error types that were previously being applied to the old tests.
alexgromero
pushed a commit
to alexgromero/botocore
that referenced
this pull request
Oct 8, 2024
This fixes a pair of event stream tests. Implementations of `application/vnd.amazon.eventstream` are expected to check the CRC before attempting to semantically parse the prelude. The tests meant to enforce that were present, but the wrong error was being asserted. This change fixes the ordering of checks, fixes the tests, and adds two new test cases to make assertions about the error types that were previously being applied to the old tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a pair of event stream tests. Implementations of
application/vnd.amazon.eventstreamare expected to check the CRC before attempting to semantically parse the prelude. The tests meant to enforce that were present, but the wrong error was being asserted.This change fixes the ordering of checks, fixes the tests, and adds two new test cases to make assertions about the error types that were previously being applied to the old tests.