Fix regression when handling 200 error responses from S3 #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now do not try to parse the error response unless it's an error HTTP status code. This means the handler needs to be updated such that _it_ is the one that does the Error parsing. Fortunately, we don't need to fully parse the XML error response. We just need to know that the top level key is an Error node before saying we need to retry the request.
|
LGTM 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now do not try to parse the error response unless it's an error
HTTP status code. This means the handler needs to be updated such
that it is the one that does the Error parsing. Fortunately, we
don't need to fully parse the XML error response. We just need to
know that the top level key is an Error node before saying we
need to retry the request.
cc @danielgtaylor @kyleknap