Dont use DNS style addressing for GetBucketLocation #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bypasses an issue when you try to get bucket location for a bucket in eu-central-1. You now do not need a region specified.
| # Also keep in mind that while this test is useful, it doesn't test | ||
| # what happens once DNS propogates which is arguably more interesting, | ||
| # as DNS will point us to the eu-central-1 endpoint. | ||
| response = operation.call(self.endpoint, Bucket=self.bucket_name) |
There was a problem hiding this comment.
Is the endpoint region being used is "eu-central-1" still? I would like to see using different regions for endpoints.
There was a problem hiding this comment.
It's not obvious from this test, but self.endpoint is actually the endpoint for us-east-1, defined in the base classes's setUp.
There was a problem hiding this comment.
Oh my bad. I saw endpoint in the setUp() and assumed it was self.endpoint
|
LGTM. Just had some questions about the tests. |
|
@kyleknap fixed up the tests to use clients in the text fixtures. Also just went ahead and created a new us-east-1 endpoint to make it more clear that we're testing us-east-1. |
|
Thanks. LGTM. 🚢 |
jamesls
added a commit
that referenced
this pull request
Nov 18, 2014
* no-dns-bucket-location: Fix up test to use client objects in test fixtures Dont use DNS style addressing for GetBucketLocation Conflicts: tests/unit/test_handlers.py Closes #380
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue when you try to get bucket location
for a bucket in eu-central-1. You now do not need a region
specified.
For example, you previously needed:
which defeated the purpose of get-bucket-location. Now the region doesn't matter:
cc @kyleknap @danielgtaylor