Add compat for legacy operation methods on waiters #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While pulling in boto#437, I noticed that we aren't handling the 'error' matcher properly because of a CLI customization that will raise an error on non 200 responses. This handles that case so, for example, the command `aws rds wait db-instance-deleted --db-instance-identifier foo` will work as expected. Previously, the error was being propogated and the CLI command would exit with a non-zero RC and a client error message.
|
This looks good. 🚢 As a note if you want to add an integration test for this in the CLI, |
|
Sounds good. I'll send a PR for a CLI integration test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While pulling in #437,
I noticed that we aren't handling the 'error' matcher properly
because of a CLI customization that will raise an error on
non 200 responses. This handles that case so, for example, the
command
aws rds wait db-instance-deleted --db-instance-identifier foowill work as expected. Previously, the error was being propogated
and the CLI command would exit with a non-zero RC and a client error
message.
cc @kyleknap @danielgtaylor