Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build_full_result for clients #485

Merged
merged 1 commit into from
Mar 10, 2015

Conversation

kyleknap
Copy link
Contributor

Fixes build_full_result() for clients.

Before this would happen:

>>> import botocore.session
>>> session = botocore.session.get_session()
>>> client = session.create_client('s3')
>>> paginator = client.get_paginator('list_objects')
>>> pages = paginator.paginate(Bucket='mybucketfoo')
>>> pages.build_full_result()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "botocore/paginate.py", line 215, in build_full_result
    for _, page in self:
ValueError: too many values to unpack

Now this lists all of my objects.

Note that I only included that one unit test for clients to have a smoke test even though operation objects have much more tests. I was considering switching all of the operation object pagination test to clients, but I was hesitant to do that since the CLI still uses operation object pagination. Let me know what you think.

cc @jamesls @danielgtaylor

@jamesls
Copy link
Member

jamesls commented Mar 10, 2015

:shipit:

kyleknap added a commit that referenced this pull request Mar 10, 2015
@kyleknap kyleknap merged commit 2eee0f1 into boto:develop Mar 10, 2015
@kyleknap kyleknap deleted the build-full-result-clients branch March 10, 2015 19:31
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) to 94.55% when pulling 7867b40 on kyleknap:build-full-result-clients into d2792df on boto:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants