Simplify retry configuration #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes two things: * Move the ``throttling_exception`` rule up to the default errors to retry * Move the ``throttling`` rule up to the default errors to retry This came about because the ``workspaces`` service would receive 400/ThrottlingException errors that were not being retried. The simple fix would be to add this missing condition to a new ``workspaces`` entry. However, the error can occur for any json or rest-json service and we'd need to keep this up to date every time we added support for a new json/rest-json service. Same thing with the 400/Throttling exception. This will happen for any query service. Moving this up to the default set of errors to retry means we won't have to keep updating this as new errors are added. It also has the benefit that the remaining per-service conditions are just the special cases.
1 similar comment
|
Makes sense. Looks good. 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes two things:
throttling_exceptionrule up to the default errors to retrythrottlingrule up to the default errors to retryThis came about because the
workspacesservice would receive400/ThrottlingException errors that were not being retried.
The simple fix would be to add this missing condition to a new
workspacesentry.However, the error can occur for any json or rest-json service and
we'd need to keep this up to date every time we added support for a new
json/rest-json service. Same thing with the 400/Throttling exception.
This will happen for any query service. Moving this up to the default
set of errors to retry means we won't have to keep updating this as new
errors are added.
It also has the benefit that the remaining per-service conditions are
just the special cases.
cc @kyleknap