Pass service_signing_name to ClientEndpointBridge #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was being passed as the 4th positional argument to ClientEndpointBridge which is the ``default_endpoint``, not the ``service_signing_name``. Passing this value as a kwarg to be explicit. I also fixed a case where the signingName from the service was not being used in the case where we assume an endpoint if we can't resolve anything from the endpoint resolver. Fixes boto/boto3#538
|
🚢 I can confirm it works as well |
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was being passed as the 4th positional argument
to ClientEndpointBridge which is the
default_endpoint,not the
service_signing_name. Passing this valueas a kwarg to be explicit.
I also fixed a case where the signingName from the service
was not being used in the case where we assume an endpoint
if we can't resolve anything from the endpoint resolver.
Fixes boto/boto3#538
cc @kyleknap @JordonPhillips