chore(zui): drastically improve zui test speed by removing toBeValidTypescript custom expect #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypescript custom expect
franklevasseur
commented
Nov 15, 2024
There was a problem hiding this comment.
note: These tests are stupid, but the goal of this PR was not to remove tests but to make them faster. This is the closest I could get to the original tests.
pascal-botpress
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom vitest expect
toBeValidTypescriptbelowwas unbelievably slow.
By migrating to proper tests with clear expected values, the test execution time goes down by a factor of more than 10x (~140s to ~10s)