Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ecs-updater dependencies #114

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Upgrade ecs-updater dependencies #114

merged 1 commit into from
Mar 9, 2023

Conversation

yeazelm
Copy link
Contributor

@yeazelm yeazelm commented Mar 9, 2023

Related to bottlerocket-os/bottlerocket-sdk#87
and captures using Go 1.19.4

Description of changes:

  • Upgrades aws sdk
  • Upgrades bottlerocket sdk image

Testing done:
Build image and ran upgrade tests myself from integ/

./run-updater.sh --cluster ecs-updater-integ-cluster  --updater-image ${account_id}.dkr.ecr.us-west-2.amazonaws.com/bottlerocket-ecs-updater:latest
INFO: ECS updater is running on cluster 'ecs-updater-integ-cluster'. Check logs in Cloudwatch LogGroup 'bottlerocket-ecs-updater-integ'

# From the CW Logs:
....
  | 2023-03-09T11:55:32.533-08:00 | 2023/03/09 19:55:32: Instance updated successfully
  | 2023-03-09T11:55:32.533-08:00 | 2023/03/09 19:55:32 Update operations complete!

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

jpmcb
jpmcb approved these changes Mar 9, 2023
View reviewed changes
updater/go.sum
@@ -18,31 +18,27 @@ github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO
github.com/stretchr/testify v1.8.1 h1:w7B6lhMri9wdJUVmEZPGGhZzrYTPvgJArz7wNPgYKsk=
github.com/stretchr/testify v1.8.1/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o6fzry7u4=
github.com/yuin/goldmark v1.4.13/go.mod h1:6yULJ656Px+3vBD8DxQVa3kxgyrAnzto9xy5taEt/CY=
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Glad to get rid of these old versons of crypto and net 👏🏼

@jpmcb jpmcb mentioned this pull request Mar 9, 2023
Closed
@yeazelm yeazelm merged commit 9ecdd66 into bottlerocket-os:develop Mar 9, 2023
@yeazelm yeazelm deleted the go_deps branch March 9, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcginnis stmcginnis stmcginnis approved these changes

@jpmcb jpmcb jpmcb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yeazelm @stmcginnis @jpmcb