Removes bunyan JSON style logging
#298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced with "pretty", human readable logs. This will enable kubernetes users to more easily debug and view their logs. Signed-off-by: John McBride <jpmmcb@amazon.com>
gthao313
approved these changes
Oct 13, 2022
webern
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #148
Description of changes:
Removes the
bunyanJSON style logging in favor of human readable, "pretty" logs.Testing done:
Here's a before:
And after:
Did some further validation with kubernetes logging. Built a kind cluster locally:
Built the image:
Loaded the local image into my kind cluster
And made modifications to the
imagetags in the manifest:Logs are lookin nice!
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.