Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes bunyan JSON style logging #298

Merged
merged 1 commit into from
Oct 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion agent/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ futures = "0.3"
opentelemetry = { version = "0.16", features = ["rt-tokio-current-thread"] }
tracing = "0.1"
tracing-subscriber = { version = "0.3", features = ["registry", "env-filter"] }
tracing-bunyan-formatter = "0.3"
tracing-opentelemetry = "0.16"

# k8s-openapi must match the version required by kube and enable a k8s version feature
Expand Down
6 changes: 2 additions & 4 deletions agent/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ use models::node::{brs_name_from_node_name, BottlerocketShadow};
use opentelemetry::sdk::propagation::TraceContextPropagator;
use snafu::{OptionExt, ResultExt};
use tracing::{event, Level};
use tracing_bunyan_formatter::{BunyanFormattingLayer, JsonStorageLayer};
use tracing_subscriber::{layer::SubscriberExt, EnvFilter, Registry};
use tracing_subscriber::{fmt, layer::SubscriberExt, EnvFilter, Registry};

use std::env;
use std::fs;
Expand Down Expand Up @@ -117,10 +116,9 @@ pub fn init_telemetry() -> Result<()> {
opentelemetry::global::set_text_map_propagator(TraceContextPropagator::new());

let env_filter = EnvFilter::try_from_default_env().unwrap_or_else(|_| EnvFilter::new("info"));
let stdio_formatting_layer = BunyanFormattingLayer::new(AGENT.into(), std::io::stdout);
let stdio_formatting_layer = fmt::layer().pretty();
let subscriber = Registry::default()
.with(env_filter)
.with(JsonStorageLayer)
.with(stdio_formatting_layer);
tracing::subscriber::set_global_default(subscriber)
.context(agent_error::TracingConfigurationSnafu)?;
Expand Down
1 change: 0 additions & 1 deletion apiserver/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ opentelemetry = { version = "0.16", features = ["rt-tokio-current-thread"]}
opentelemetry-prometheus = "0.9"
tracing = "0.1"
tracing-actix-web = "0.4.0-beta.14"
tracing-bunyan-formatter = "0.3"
tracing-subscriber = { version = "0.3", features = ["registry", "env-filter"] }
tracing-opentelemetry = "0.16"

Expand Down
6 changes: 2 additions & 4 deletions apiserver/src/telemetry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ use opentelemetry::sdk::propagation::TraceContextPropagator;
use snafu::ResultExt;
use tracing::Span;
use tracing_actix_web::{DefaultRootSpanBuilder, RootSpanBuilder};
use tracing_bunyan_formatter::{BunyanFormattingLayer, JsonStorageLayer};
use tracing_subscriber::{layer::SubscriberExt, EnvFilter, Registry};
use tracing_subscriber::{fmt, layer::SubscriberExt, EnvFilter, Registry};

use std::collections::HashSet;

Expand Down Expand Up @@ -58,10 +57,9 @@ pub fn init_telemetry() -> Result<(), telemetry_error::Error> {
opentelemetry::global::set_text_map_propagator(TraceContextPropagator::new());

let env_filter = EnvFilter::try_from_default_env().unwrap_or_else(|_| EnvFilter::new("info"));
let stdio_formatting_layer = BunyanFormattingLayer::new(APISERVER.into(), std::io::stdout);
let stdio_formatting_layer = fmt::layer().pretty();
let subscriber = Registry::default()
.with(env_filter)
.with(JsonStorageLayer)
.with(stdio_formatting_layer);
tracing::subscriber::set_global_default(subscriber)
.context(telemetry_error::TracingConfigurationSnafu)?;
Expand Down
1 change: 0 additions & 1 deletion controller/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,5 @@ serde_plain = "1.0.0"
snafu = "0.7"
tokio = { version = "1", features = ["macros", "rt-multi-thread", "time"] }
tracing = "0.1"
tracing-bunyan-formatter = "0.3"
tracing-opentelemetry = "0.16"
tracing-subscriber = { version = "0.3", features = ["registry", "env-filter"] }
6 changes: 2 additions & 4 deletions controller/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ use kube::{
use opentelemetry::sdk::propagation::TraceContextPropagator;
use snafu::ResultExt;
use tracing::{event, Level};
use tracing_bunyan_formatter::{BunyanFormattingLayer, JsonStorageLayer};
use tracing_subscriber::{layer::SubscriberExt, EnvFilter, Registry};
use tracing_subscriber::{fmt, layer::SubscriberExt, EnvFilter, Registry};

const DEFAULT_TRACE_LEVEL: &str = "info";

Expand Down Expand Up @@ -105,10 +104,9 @@ fn init_telemetry() -> Result<()> {

let env_filter =
EnvFilter::try_from_default_env().unwrap_or_else(|_| EnvFilter::new(DEFAULT_TRACE_LEVEL));
let stdio_formatting_layer = BunyanFormattingLayer::new(CONTROLLER.into(), std::io::stdout);
let stdio_formatting_layer = fmt::layer().pretty();
let subscriber = Registry::default()
.with(env_filter)
.with(JsonStorageLayer)
.with(stdio_formatting_layer);
tracing::subscriber::set_global_default(subscriber)
.context(controller_error::TracingConfigurationSnafu)?;
Expand Down