Integ test - creation/deletion of brupop and test pods improvement #217
Conversation
gthao313
changed the title
gthao313
changed the title
integ/src/updater.rs
Outdated
| //therefore, skips test pods creation if those pods already exist. | ||
| // This wouldn't affect pods deletion. | ||
| let error_content = String::from_utf8_lossy(&brupop_resource_output.stderr).to_string(); | ||
| match error_content.contains("AlreadyExists") { |
There was a problem hiding this comment.
nit: IMO it's simpler to just use if instead of match on a boolean expression.
Integration test allows to launch multiple nodegroups on eks cluster, and it would be redundant to create test pods multiple times. Therefore this change make system to skip creating test pods if they already exist.
Integration test allows to launch multiple nodegroups on eks cluster, and it would be redundant to create brupop resources multiple times. Therefore this change make system to skip creating brupop resources if they already exist. Meanwhile, simplify the functionality of create and delete brupop resources.
gthao313
force-pushed
the
integ-test-bug-fix
branch
from
095ea32
to
f3bcb51
Compare
|
Ideally, we have to clean up integration test when we need test a code change. However, during brupop release process, we need test arm and amd at same time (run Solution: run Hence, more than once integration test at same time will not fail on resource |
| let brupop_resource_status = Command::new(KUBECTL_BINARY) | ||
| .args([ | ||
| "apply", | ||
| &action_string.to_lowercase(), |
There was a problem hiding this comment.
How do you plan to handle deletion failure? I know sometimes the deletion get stuck and need to manually patch the resource especially during the CRD update. Does it make sense to set up a timeout on deletion and print the manual patch command?
There was a problem hiding this comment.
Can you share what situations you had met?
There was a problem hiding this comment.
We had a discussion offline and decided to open an new issue if the above situation happens.
Issue number:
#216
#208
Description of changes:
Testing done:
Method: Launch multiple nodegroup and check if brupop resources and test pods are created only once (first nodegroup)
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.