platform api: list update when non-nil

[jahkeup]

Issue number:

n/a

Description of changes:

When using the update-api update platform, the node lists itself as having updates available when it does not. This is because the response includes a nil update in its list. The update itself isn't inspected and instead the response is checked for len(availableUpdatesResponse.Updates()) > 0. The nil element makes this evaluate to true and then the node will cycle through update attempts.

Testing done:

Nodes in a cluster running Bottlerocket 0.5.0 upgrades successfully to an artificial 0.5.1 then stabilize.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

[samuelkarp]

When using the update-api update platform, the node lists itself as having updates available when it does not. This is because the response includes a nil update in its list.

Do we have an issue to track this bug in the update API?

[etungsten]

When using the update-api update platform, the node lists itself as having updates available when it does not. This is because the response includes a nil update in its list.

Do we have an issue to track this bug in the update API?

This is an issue specific to the update-api platform in brupop.
The update API return structure looks like:

{
   "update_state":"Idle",
   "available_updates":[
      "0.5.0"
   ],
   "chosen_update":null,
   "active_partition":{
      "image":{
         "arch":"aarch64",
         "version":"0.5.0",
         "variant":"aws-k8s-1.17"
      },
      "next_to_boot":true
   },
   "staging_partition":null,
   "most_recent_command":{
      "cmd_type":"refresh",
      "cmd_status":"Success",
      "timestamp":"2020-08-20T18:44:43.574977236Z",
      "exit_status":0,
      "stderr":""
   }
}