Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unnecessary dep on older "time" crate from chrono #415

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

jpmcb
Copy link
Contributor

@jpmcb jpmcb commented Feb 15, 2023

Issue number:

N/a - inspired by awslabs/tough#506 and bottlerocket-os/bottlerocket#2748 (shout out to @jpculp for bringing this to our attention!). This should also resolve any references to RUSTSEC-2020-0071.

Description of changes:

Removes the unnecessary dependency on the older time version brought in by chrono

Testing done:

Doing integration tests now ... stay tuned!

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Signed-off-by: John McBride <jpmmcb@amazon.com>
Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are happy and this looks good to me.

@jpmcb
Copy link
Contributor Author

jpmcb commented Feb 16, 2023

Integration tests are looking 👌🏼

❯ k get brs -A
NAMESPACE                 NAME                                                STATE   VERSION   TARGET STATE   TARGET VERSION   CRASH COUNT
brupop-bottlerocket-aws   brs-ip-192-168-143-224.us-west-2.compute.internal   Idle    1.12.0    Idle                            0
brupop-bottlerocket-aws   brs-ip-192-168-152-59.us-west-2.compute.internal    Idle    1.12.0    Idle                            0
brupop-bottlerocket-aws   brs-ip-192-168-156-75.us-west-2.compute.internal    Idle    1.12.0    Idle                            0

@jpmcb jpmcb merged commit 3a23dec into bottlerocket-os:develop Feb 16, 2023
@jpmcb jpmcb deleted the chrono-no-time branch February 16, 2023 22:01
@gthao313 gthao313 mentioned this pull request Jul 7, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants