-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable configuration of log formatting #503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not deployed, but code review-wise everything looks good and the test coverage gives me confidence. ;)
6c4a304
to
c621dcc
Compare
^ I forgot to run clippy 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've had clippy point me at map
way too often. :D
Issue number:
Closes #493
Description of changes:
This provides the ability to specify log formatting options via helm. You can control:
See the updated README for more details
Testing done:
Launched a cluster with
logging_ansi_enabled: "false"
andlogging_formatter: "full"
and noted the logs:Then again with
logging_formatter: "json"
:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.