Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm-chart): enable podlabels configuration #617

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

danielvincenzi
Copy link

Issue number: #616

Description of changes: Add optional podLabels to the Deployment and DaemonSet.

Testing done: Yes, only locally.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@alexandrempm
Copy link

Great :-)

Copy link

@alexaln30 alexaln30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArthurHLG
Copy link

Approved

@ytsssun
Copy link
Contributor

ytsssun commented Apr 12, 2024

Hi @danielvincenzi, thanks for cutting us this PR. I have done below tests to verify the behavior and it is working fine for me:

  1. Upgrade the brupop via local chart
  2. Use a sample value.yaml.
scheduler_cron_expression: '* 23 * * * Sun *'
podLabels:
  app: "brupop-test"
  environment: "beta"
  1. Run helm upgrade brupop-operator deploy/charts/bottlerocket-update-operator -f values.yaml
  2. Get the pods labels:
» kubectl get pods --namespace brupop-bottlerocket-aws --show-labels                                                   1 ↵
NAME                                         READY   STATUS    RESTARTS   AGE     LABELS
brupop-agent-dlppb                           1/1     Running   0          3m13s   app=brupop-test,brupop.bottlerocket.aws/component=agent,controller-revision-hash=67b54459db,environment=beta,pod-template-generation=3
brupop-agent-ffrtw                           1/1     Running   0          3m49s   app=brupop-test,brupop.bottlerocket.aws/component=agent,controller-revision-hash=67b54459db,environment=beta,pod-template-generation=3
brupop-agent-qg4g9                           1/1     Running   0          2m37s   app=brupop-test,brupop.bottlerocket.aws/component=agent,controller-revision-hash=67b54459db,environment=beta,pod-template-generation=3
brupop-apiserver-6bb84bcb55-72xj9            1/1     Running   0          3m58s   app=brupop-test,brupop.bottlerocket.aws/component=apiserver,environment=beta,pod-template-hash=6bb84bcb55
brupop-apiserver-6bb84bcb55-fkhh6            1/1     Running   0          4m19s   app=brupop-test,brupop.bottlerocket.aws/component=apiserver,environment=beta,pod-template-hash=6bb84bcb55
brupop-apiserver-6bb84bcb55-mmcww            1/1     Running   0          4m8s    app=brupop-test,brupop.bottlerocket.aws/component=apiserver,environment=beta,pod-template-hash=6bb84bcb55

The labels are applied to the pods as expected!

Only thing I would kindly request here is that, could you also help update the READMEs to reflect this new value?
Candidates:

@ytsssun ytsssun merged commit 69e2aec into bottlerocket-os:develop Apr 29, 2024
2 checks passed
@cbgbt cbgbt mentioned this pull request Jun 26, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants