-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm-chart): enable podlabels configuration #617
Conversation
Great :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Approved |
Hi @danielvincenzi, thanks for cutting us this PR. I have done below tests to verify the behavior and it is working fine for me:
The labels are applied to the pods as expected! Only thing I would kindly request here is that, could you also help update the READMEs to reflect this new value? |
Issue number: #616
Description of changes: Add optional
podLabels
to the Deployment and DaemonSet.Testing done: Yes, only locally.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.