Skip to content

Commit

Permalink
Merge pull request #1312 from tjkirch/rpm2img-name
Browse files Browse the repository at this point in the history
Pass BUILDSYS_NAME to rpm2img so we use requested image name prefix
  • Loading branch information
tjkirch authored Feb 9, 2021
2 parents 16b868b + 429b435 commit 14dc4dd
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
3 changes: 2 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,9 @@ ARG VERSION_ID
ARG BUILD_ID
ARG NOCACHE
ARG VARIANT
ARG IMAGE_NAME
ARG IMAGE_FORMAT
ENV VARIANT=${VARIANT} VERSION_ID=${VERSION_ID} BUILD_ID=${BUILD_ID} IMAGE_FORMAT=${IMAGE_FORMAT}
ENV VARIANT=${VARIANT} VERSION_ID=${VERSION_ID} BUILD_ID=${BUILD_ID} IMAGE_NAME=${IMAGE_NAME} IMAGE_FORMAT=${IMAGE_FORMAT}
WORKDIR /root

USER root
Expand Down
3 changes: 3 additions & 0 deletions tools/buildsys/src/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ impl VariantBuilder {
let version_image = getenv("BUILDSYS_VERSION_IMAGE")?;
let version_build = getenv("BUILDSYS_VERSION_BUILD")?;
let output_dir: PathBuf = getenv("BUILDSYS_OUTPUT_DIR")?.into();
let image_name = getenv("BUILDSYS_NAME")?;
let image_format = match image_format {
Some(ImageFormat::Raw) | None => String::from("raw"),
Some(ImageFormat::Vmdk) => String::from("vmdk"),
Expand All @@ -108,12 +109,14 @@ impl VariantBuilder {
--build-arg VARIANT={variant} \
--build-arg VERSION_ID={version_image} \
--build-arg BUILD_ID={version_build} \
--build-arg IMAGE_NAME={image_name} \
--build-arg IMAGE_FORMAT={image_format}",
packages = packages,
arch = arch,
variant = variant,
version_image = version_image,
version_build = version_build,
image_name = image_name,
image_format = image_format,
);
let tag = format!(
Expand Down
2 changes: 1 addition & 1 deletion tools/rpm2img
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ esac

mkdir -p "${OUTPUT_DIR}"

FILENAME_PREFIX="bottlerocket-${VARIANT}-${ARCH}-${VERSION_ID}-${BUILD_ID}"
FILENAME_PREFIX="${IMAGE_NAME}-${VARIANT}-${ARCH}-${VERSION_ID}-${BUILD_ID}"

DISK_IMAGE_BASENAME="${FILENAME_PREFIX}"
DATA_IMAGE_BASENAME="${FILENAME_PREFIX}-data"
Expand Down

0 comments on commit 14dc4dd

Please sign in to comment.