kubelet: improve registryPullQPS and registryBurst

Handlebars built-in IF helper treats "0" (zero) as false. We need use `includeZero` flag to make sure IF HELPER treats "0" (zero) as true, so "0" (zero) can be passed to registryPullQPS and registryBurst.
bottlerocket-os · Apr 30, 2021 · a9d7890 · a9d7890
1 parent f65be1c
commit a9d7890
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/packages/kubernetes-1.16/kubelet-config b/packages/kubernetes-1.16/kubelet-config
@@ -40,10 +40,10 @@ evictionHard:
 {{~#if settings.kubernetes.allowed-unsafe-sysctls}}
 allowedUnsafeSysctls: {{settings.kubernetes.allowed-unsafe-sysctls}}
 {{~/if}}
-{{~#if settings.kubernetes.registry-qps}}
+{{~#if settings.kubernetes.registry-qps includeZero=true}}
 registryPullQPS: {{settings.kubernetes.registry-qps}}
 {{~/if}}
-{{~#if settings.kubernetes.registry-burst}}
+{{~#if settings.kubernetes.registry-burst includeZero=true}}
 registryBurst: {{settings.kubernetes.registry-burst}}
 {{~/if}}
 {{~#if settings.kubernetes.event-qps includeZero=true}}

diff --git a/packages/kubernetes-1.17/kubelet-config b/packages/kubernetes-1.17/kubelet-config
@@ -40,10 +40,10 @@ evictionHard:
 {{~#if settings.kubernetes.allowed-unsafe-sysctls}}
 allowedUnsafeSysctls: {{settings.kubernetes.allowed-unsafe-sysctls}}
 {{~/if}}
-{{~#if settings.kubernetes.registry-qps}}
+{{~#if settings.kubernetes.registry-qps includeZero=true}}
 registryPullQPS: {{settings.kubernetes.registry-qps}}
 {{~/if}}
-{{~#if settings.kubernetes.registry-burst}}
+{{~#if settings.kubernetes.registry-burst includeZero=true}}
 registryBurst: {{settings.kubernetes.registry-burst}}
 {{~/if}}
 {{~#if settings.kubernetes.event-qps includeZero=true}}

diff --git a/packages/kubernetes-1.18/kubelet-config b/packages/kubernetes-1.18/kubelet-config
@@ -40,10 +40,10 @@ evictionHard:
 {{~#if settings.kubernetes.allowed-unsafe-sysctls}}
 allowedUnsafeSysctls: {{settings.kubernetes.allowed-unsafe-sysctls}}
 {{~/if}}
-{{~#if settings.kubernetes.registry-qps}}
+{{~#if settings.kubernetes.registry-qps includeZero=true}}
 registryPullQPS: {{settings.kubernetes.registry-qps}}
 {{~/if}}
-{{~#if settings.kubernetes.registry-burst}}
+{{~#if settings.kubernetes.registry-burst includeZero=true}}
 registryBurst: {{settings.kubernetes.registry-burst}}
 {{~/if}}
 {{~#if settings.kubernetes.event-qps includeZero=true}}

diff --git a/packages/kubernetes-1.19/kubelet-config b/packages/kubernetes-1.19/kubelet-config
@@ -40,10 +40,10 @@ evictionHard:
 {{~#if settings.kubernetes.allowed-unsafe-sysctls}}
 allowedUnsafeSysctls: {{settings.kubernetes.allowed-unsafe-sysctls}}
 {{~/if}}
-{{~#if settings.kubernetes.registry-qps}}
+{{~#if settings.kubernetes.registry-qps includeZero=true}}
 registryPullQPS: {{settings.kubernetes.registry-qps}}
 {{~/if}}
-{{~#if settings.kubernetes.registry-burst}}
+{{~#if settings.kubernetes.registry-burst includeZero=true}}
 registryBurst: {{settings.kubernetes.registry-burst}}
 {{~/if}}
 {{~#if settings.kubernetes.event-qps includeZero=true}}

diff --git a/packages/kubernetes-1.20/kubelet-config b/packages/kubernetes-1.20/kubelet-config
@@ -40,10 +40,10 @@ evictionHard:
 {{~#if settings.kubernetes.allowed-unsafe-sysctls}}
 allowedUnsafeSysctls: {{settings.kubernetes.allowed-unsafe-sysctls}}
 {{~/if}}
-{{~#if settings.kubernetes.registry-qps}}
+{{~#if settings.kubernetes.registry-qps includeZero=true}}
 registryPullQPS: {{settings.kubernetes.registry-qps}}
 {{~/if}}
-{{~#if settings.kubernetes.registry-burst}}
+{{~#if settings.kubernetes.registry-burst includeZero=true}}
 registryBurst: {{settings.kubernetes.registry-burst}}
 {{~/if}}
 {{~#if settings.kubernetes.event-qps includeZero=true}}