Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to tough v0.11.0, tokio 1.0, rusoto 0.46, reqwest v0.11. #1269

Closed
webern opened this issue Jan 9, 2021 · 7 comments · Fixed by #1479
Closed

update to tough v0.11.0, tokio 1.0, rusoto 0.46, reqwest v0.11. #1269

webern opened this issue Jan 9, 2021 · 7 comments · Fixed by #1479
Assignees
Labels
type/enhancement New feature or request
Milestone

Comments

@webern
Copy link
Contributor

webern commented Jan 9, 2021

The rust packages listed in the title are intertwined in various ways.

Multiple major-versions of tokio can not be in use at a given time. rusoto 0.46, hyper 14 and reqwest v0.11 all bump to tokio v1.0. Meanwhile, we cannot have multiple versions of reqwest in the sources workspace because of the way webpki-root-shim works. So, basically what needs to happen is this awslabs/tough#269 needs to land and get published (I'm calling it v0.11.0 since v0.10.0 is already a huge diff), and then all the Bottlerocket stuff can update.

Edit: remember to remove the https-proxy workarounds in metricdog and updog, see #1332

@tjkirch
Copy link
Contributor

tjkirch commented Feb 24, 2021

inotify is another dependency that updated because of tokio.

@tjkirch
Copy link
Contributor

tjkirch commented Feb 24, 2021

Also httptest.

@tjkirch
Copy link
Contributor

tjkirch commented Feb 24, 2021

Also coldsnap, which needs to do a new release that includes the change it made to use tokio 1.

@webern
Copy link
Contributor Author

webern commented Feb 25, 2021

Also coldsnap, which needs to do a new release that includes the change it made to use tokio 1.

Good catch, opened this PR to get it done awslabs/coldsnap#46

@webern
Copy link
Contributor Author

webern commented Mar 3, 2021

OK, coldsnap and tough dependencies are published so this should be unblocked.

@webern
Copy link
Contributor Author

webern commented Mar 10, 2021

tools has been updated to use tokio v1. Bottlerocket (i.e. sources) has not because we need actix-web 4.0.

@gregdek gregdek added the status/blocked Issue is blocked waiting on something external label Mar 24, 2021
@gregdek gregdek added this to the next milestone Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants