-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update cargo dependencies #1267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please also check (1) unit tests and (2) that apiclient can change/commit/apply settings?
Does https://github.com/kbknapp/cargo-outdated show any bigger updates we need to apply? (modulo tokio, gptman) Does https://github.com/est31/cargo-udeps show anything unused? (careful with that one...)
Expanded to include all reasonable major updates. No udeps found. Unit tests pass (btw they run in CI as well). I still need to repeat the testing that I listed in the PR description and add to that the apiclient tests suggested above. Created two follow-up issues #1268 and #1269 for major dep upgrades that require follow-up. |
Update: I repeated the testing (and added a test of apiclient) after dep major updates in c76670b and everything seems to be working. |
Addresses @srgothi92 's findings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little hesitant about updating tough, just to change the migrator code back for the re-removed lifetime stuff in 0.10, but I don't mind if you prefer it.
Also bump webpki-roots-shim to v0.20.0 so that reqwest continues to use it.
Undo:
|
Issue number:
N/A
Description of changes:
cargo update, once in tools and once in sources.
Needed to bump the version of webpki-roots-shim to match what reqwest is using.
Testing done:
cargo make, cargo make ami and cargo make repo. Ran k8s 1.17, ran a pod. Also ssh'ed in and updog check-update worked.
Also checked
apiclient
with the following commands, which successfully changed themotd
setting.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.