Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass all arguments related to soft eviction to the kubelet #1445

Closed
gthao313 opened this issue Apr 5, 2021 · 0 comments · Fixed by #2930
Closed

Pass all arguments related to soft eviction to the kubelet #1445

gthao313 opened this issue Apr 5, 2021 · 0 comments · Fixed by #2930
Assignees
@stmcginnis
Labels
area/kubernetes K8s including EKS, EKS-A, and including VMW area/settings Issues related to our settings handling status/in-progress This issue is currently being worked on type/enhancement New feature or request

Comments

@gthao313
Copy link
Member

gthao313 commented Apr 5, 2021 •
edited

This is awesome - we've built an AMI with this patch and its working wonderfully. In a followup PR, we'd like to see the evictionSoft settings exposed, as well as the eviction-max-pod-grace-period setting. Overall though, this is great!

Originally posted by @diranged in #1388 (comment)

What I'd like:
Support customer to pass all arguments related to soft eviction to Kubelet in Bottlerocket. https://kubernetes.io/docs/tasks/administer-cluster/out-of-resource/#soft-eviction-thresholds
@gthao313 gthao313 self-assigned this Apr 5, 2021
@gthao313 gthao313 changed the title Pass evictionSoft and eviction-max-pod-grace-period to the kubelet Pass all arguments related to soft eviction to the kubelet Apr 5, 2021
@gthao313 gthao313 changed the title Pass all arguments related to soft eviction to the kubelet Pass all arguments related to soft eviction to the kubelet Apr 5, 2021
@jhaynes jhaynes added area/kubernetes K8s including EKS, EKS-A, and including VMW status/needs-triage Pending triage or re-evaluation type/enhancement New feature or request labels Apr 5, 2021
@gthao313 gthao313 mentioned this issue Apr 5, 2021
Merged
@jhaynes jhaynes added this to the backlog milestone Apr 9, 2021
@jhaynes jhaynes added priority/p2 and removed status/needs-triage Pending triage or re-evaluation labels May 3, 2021
@stmcginnis stmcginnis added status/needs-triage Pending triage or re-evaluation and removed priority/p2 labels Dec 1, 2022
@stmcginnis stmcginnis removed this from the backlog milestone Feb 23, 2023
@stmcginnis stmcginnis added good first issue May be a good issue for new contributors status/icebox Things we think would be nice but are not prioritized area/settings Issues related to our settings handling and removed status/needs-triage Pending triage or re-evaluation labels Feb 23, 2023
@stmcginnis stmcginnis self-assigned this Mar 21, 2023
@stmcginnis stmcginnis mentioned this issue Mar 22, 2023
Merged
@stmcginnis stmcginnis added status/in-progress This issue is currently being worked on and removed good first issue May be a good issue for new contributors status/icebox Things we think would be nice but are not prioritized labels Mar 22, 2023
@lolbrish lolbrish mentioned this issue Jun 20, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stmcginnis stmcginnis

Labels
area/kubernetes K8s including EKS, EKS-A, and including VMW area/settings Issues related to our settings handling status/in-progress This issue is currently being worked on type/enhancement New feature or request
Projects
Bottlerocket Engineering Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Additional kubelet configuration settings stmcginnis/bottlerocket
3 participants
@jhaynes @stmcginnis @gthao313