chore: Add soft eviction setting to Bottlerocket kublet config #6390
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
| func (b Bottlerocket) FeatureFlags() FeatureFlags { | ||
| return FeatureFlags{ | ||
| UsesENILimitedMemoryOverhead: false, | ||
| PodsPerCoreEnabled: false, | ||
| EvictionSoftEnabled: false, |
There was a problem hiding this comment.
I don't even think we need the feature flag at all now since I believe they are all true now. You can probably just drop the field outright from the struct now
| @@ -64,6 +64,18 @@ func (b Bottlerocket) Script() (string, error) { | |||
| if b.KubeletConfig.EvictionHard != nil { | |||
| s.Settings.Kubernetes.EvictionHard = b.KubeletConfig.EvictionHard | |||
| } | |||
| if b.KubeletConfig.EvictionMaxPodGracePeriod != nil { | |||
There was a problem hiding this comment.
Can we add a test (at least a functional one) for the changes that you are making here. There may also be a change that you could make to the current E2E integration testing in our Kubelet Config suite tests that would extend eviction soft testing for BR
There was a problem hiding this comment.
I'll try to take a look at this in the next few days
|
Thanks for taking this up! A few comments, mainly about testing 👍🏼 |
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Fixes #N/A
Description
Issue bottlerocket-os/bottlerocket#1445 is fixed and so soft eviction settings can now be used with Bottlerocket. It looks like old docs have already been removed that used to discuss this limitation.
How was this change tested?
Tested on a live EKS cluster to provision Bottlerocket nodes, then the kubelet configuration was checked using
http://localhost:8001/api/v1/nodes/$NODE/proxy/configz.Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.