Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsys: don't thread bomb in validate-repo #1522

Closed
webern opened this issue Apr 23, 2021 · 1 comment · Fixed by #1564
Closed

pubsys: don't thread bomb in validate-repo #1522

webern opened this issue Apr 23, 2021 · 1 comment · Fixed by #1564
Assignees
@webern
Labels
type/bug Something isn't working
Milestone
v1.1.2

Comments

@webern
Copy link
Contributor

webern commented Apr 23, 2021

in #1521 we did a quick fix of pubsys validate-repo where we spawn a new thread for every target in the Bottlerocket artifacts repo. Instead we should have a pool or otherwise limit the number of threads spawned.

Background: we were using tokio::spawn before (which has its own thread management), but we found that multiple tokio runtimes were being created which caused the program to hang. The quick fix was to spawn threads to get the program working again.
@webern webern added the type/bug Something isn't working label Apr 23, 2021
@etungsten etungsten added priority/p0 status/needs-triage Pending triage or re-evaluation labels Apr 23, 2021
@webern
Copy link
Contributor Author

webern commented Apr 25, 2021

Maybe futures::executer

@webern webern self-assigned this Apr 28, 2021
@jhaynes jhaynes added this to the techdebt milestone May 3, 2021
@jhaynes jhaynes added status/notstarted and removed status/needs-triage Pending triage or re-evaluation labels May 3, 2021
@webern webern modified the milestones: techdebt, next May 5, 2021
@webern webern added status/in-progress This issue is currently being worked on and removed status/notstarted labels May 6, 2021
@webern webern mentioned this issue May 6, 2021
Merged
@bcressey bcressey removed the status/in-progress This issue is currently being worked on label Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@webern webern

Labels
type/bug Something isn't working
Projects
None yet
Milestone
v1.1.2
Development

Successfully merging a pull request may close this issue.

pubsys: limit threads during validate-repo
4 participants
@bcressey @jhaynes @webern @etungsten