pubsys: validate-repo without tokio runtime #1521
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Description of changes:
We were seeing
pubsys validate-repo
hang and we believe it was because of multiple tokio runtimes. Although it's not clear whytokio::spawn
was working before, re-implementing this to usestd::thread::spawn
instead has fixed the problem.Testing done:
Created an Infra.toml like this:
And this a few times:
cargo make validate-repo \ -e PUBLISH_REPO=2020-07-07 \ -e BUILDSYS_VARIANT=aws-k8s-1.15 \ -e BUILDSYS_ARCH=x86_64 \ -e PUBLISH_INFRA_CONFIG_PATH="${INFRA_TOML}"
I also edited a target in a repo and verified that the program errors out when the repo is bad:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.