aws-ecs-1: enable task IAM role support #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahkeup
reviewed
Aug 4, 2020
webern
approved these changes
Aug 4, 2020
samuelkarp
force-pushed
the
ecs-task-role
branch
from
a3c0510 to
ff0ef94
Compare
jahkeup
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#815
Description of changes:
This change enables the task role capabilities so Bottlerocket instances become eligible for placement for tasks with roles.
Testing done:
Launched a new Bottlerocket instance. Saw the following capabilities registered successfully:
com.amazonaws.ecs.capability.task-iam-role-network-hostcom.amazonaws.ecs.capability.task-iam-roleRan two tasks using task roles, one in the
bridge(default) network mode and the other inhost(requires thetask-iam-role-network-hostcapability). Observed that the containers were able to use the role and successfully make API calls requiring permissions that were not in the instance's role.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.