Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amiize: use coldsnap to create snapshots from root/data images #1012

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented Aug 6, 2020

Description of changes:

Updates amiize to use coldsnap instead of instance/dd.

Hopefully we'll be using #1010 for most AMI creation, but I used this to practice with coldsnap, and I couldn't resist anyway. amiize is what I do...

Testing done:

...
[cargo-make] INFO - Build Done in 70 seconds.
Successfully decoded 2147483648 bytes
Successfully decoded 1073741824 bytes
root: build/images/x86_64-aws-k8s-1.17/latest/bottlerocket-aws-k8s-1.17-x86_64.img
data: build/images/x86_64-aws-k8s-1.17/latest/bottlerocket-aws-k8s-1.17-x86_64-data.img
Checking if AMI already exists with name 'bottlerocket-aws-k8s-1.17-20200806-01'
Unable to find AMI bottlerocket-aws-k8s-1.17-20200806-01
Registering an AMI from the snapshot
Registered ami-01234567890123456
Waiting for the AMI to appear in a describe query
Found AMI bottlerocket-aws-k8s-1.17-20200806-01: ami-01234567890123456 in us-west-2

SO FAST

Instance still ran pods OK.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@iliana iliana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is extremely satisfying.

Copy link
Contributor

@bcressey bcressey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐅

@tjkirch tjkirch merged commit 14451f6 into bottlerocket-os:develop Aug 7, 2020
@tjkirch tjkirch deleted the amiize-coldsnap branch August 7, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants