docker: privileged containers should have SELinux #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
approved these changes
Aug 8, 2020
packages/docker-engine/0001-bottlerocket-privileged-shouldn-t-disable-SELinux.patch
Outdated
Show resolved
Hide resolved
By default, Docker injects the equivalent of --security-opt label:disable for containers launched with the --privileged option with the intent of providing as much privilege as possible. This option disables both process and mount labeling for the container. Unfortunately, disabling labeling does not provide additional privileges when Bottlerocket's SELinux policy is enforced but instead reduces privileges. This change removes the injection of the label:disable option so privileged containers receive the same default labels as non-privileged containers. To launch a container with all SELinux labeling disabled, the explicit --security-opt label:disable can still be used. To launch a container with a label that provides additional privileges, --security-opt label:type:super_t can be used. Fixes: bottlerocket-os#1011
samuelkarp
force-pushed
the
docker-privileged-label
branch
from
ee03d2d to
c0c9775
Compare
bcressey
approved these changes
Aug 8, 2020
jamieand
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes: #1011
Description of changes:
By default, Docker injects the equivalent of
--security-opt label:disablefor containers launched with the--privilegedoption with the intent of providing as much privilege as possible. This option disables both process and mount labeling for the container. Unfortunately, disabling labeling does not provide additional privileges when Bottlerocket's SELinux policy is enforced but instead reduces privileges. This change removes the injection of thelabel:disableoption so privileged containers receive the same default labels as non-privileged containers.To launch a container with all SELinux labeling disabled, the explicit
--security-opt label:disablecan still be used.To launch a container with a label that provides additional privileges,
--security-opt label:type:super_tcan be used.Testing done:
On both an
aws-devinstance and anaws-ecs-1instance:local_tlabel. Verify that writing to the rootfs works.local_tlabel. Verify that writing to the rootfs works.--security-opt label:disable. Verify that the mount does not receive thelocal_tlabel. Verify that writing to the rootfs is denied.--security-opt label:disable. Verify that the mount does not receive thelocal_tlabel. Verify that writing to the rootfs is denied.--security-opt label:type:super_t. Verify that the mount receives the implicitlocal_tlabel. Verify that writing to the rootfs works. Verify that writing to a restricted host path like/etcworks.--security-opt label:type:super_t. Verify that the mount receives the implicitlocal_tlabel. Verify that writing to the rootfs works. Verify that writing to a restricted host path like/etcworks.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.