Build ecs-settings-applier in same cargo_build #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were rebuilding common dependencies. With the conditional in the same build block, ecs-settings-applier doesn't need to build dependencies from scratch. With the same technique, we can also simplify/deduplicate the copying of the resulting binary.
samuelkarp
approved these changes
Aug 8, 2020
bcressey
approved these changes
Aug 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were rebuilding common dependencies. With the conditional in the same build
block, ecs-settings-applier doesn't need to build dependencies from scratch.
With the same technique, we can also simplify/deduplicate the copying of the
resulting binary.
Testing done:
Before: saw 5+ minute delay from separate cargo build cycle for ecs-settings-applier.
After: Built aws-k8s-1.15, saw no change in behavior, it doesn't try to build ecs-settings-applier. Built aws-ecs-1, saw ecs-settings-applier get built in the same cycle as our other os crates. Confirmed ecs-settings-applier still shows up in the RPM.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.