Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove instructions to manually apply aws-vpc-cni #1029

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

etungsten
Copy link
Contributor

@etungsten etungsten commented Aug 11, 2020

Issue number:
N/A

Description of changes:

Author: Erikson Tung <etung@amazon.com>
Date:   Tue Aug 11 11:48:55 2020 -0700

    Remove instructions to manually apply aws-vpc-cni
    
    Creating new EKS clusters from scratch gives us a compatible aws-vpc-cni
    DaemonSet by default now.

Testing done:
Creating a fresh cluster from scratch lets me run Bottlerocket nodes in them without problems without having to manually apply these manifests.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Creating new EKS clusters from scratch gives us a compatible aws-vpc-cni
DaemonSet by default now.
Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changed to make this possible? Is it inside EKS? If it was an eksctl change, do we need to specify a minimum version now?

@etungsten
Copy link
Contributor Author

What changed to make this possible? Is it inside EKS? If it was an eksctl change, do we need to specify a minimum version now?

I think it's inside EKS. I tried creating an EKS cluster from the console and it was the same.

@etungsten etungsten merged commit f6b9401 into bottlerocket-os:develop Aug 11, 2020
@etungsten etungsten deleted the remove-cni-apply branch August 11, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants