-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
host-ctr: all devices nodes allowed when superpowered #1037
host-ctr: all devices nodes allowed when superpowered #1037
Conversation
8eec999
to
6fdc1fb
Compare
Push above is for changes after |
6fdc1fb
to
9bdc2c3
Compare
9bdc2c3
to
08fe155
Compare
08fe155
to
8d9cf84
Compare
8d9cf84
to
da62551
Compare
Separated out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK with regards to attribution on all_devices_allowed.go
// withAllDevicesAllowed permits all access on all devices nodes for the container | ||
// Taken from https://github.com/containerd/containerd/blob/25947db049b058fcbce291ef883b8b512e3ea440/oci/spec_opts.go#L1010 | ||
// which is not available in containerd v1.3.7 | ||
// TODO Once we move to containerd v1.4.0 remove this and use oci.WithAllDevicesAllowed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this become an issue, and we can reference the issue ID here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
"github.com/containerd/containerd/containers" | ||
"github.com/containerd/containerd/oci" | ||
runtimespec "github.com/opencontainers/runtime-spec/specs-go" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: if we import this as "specs" then it will get rid of most of the delta from the source
Allow access to all devices nodes when a container is superpowered
da62551
to
ce7cfb2
Compare
Push above adds a comment describing the modification to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're sticking with the drop-in function route, then.. ship it! 👍
Issue number:
N/A
Description of changes:
Testing done:
No longer getting permission errors when trying to access the partition.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.