Fix rust build caching and tune rpm compression #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
force-pushed
the
fix-rust-build-cache
branch
from
991b3a5 to
f45cdbf
Compare
samuelkarp
approved these changes
Aug 16, 2020
tjkirch
approved these changes
Aug 16, 2020
The cache directory is meant to optimize subsequent rebuilds of the crates in the "os" package. We weren't seeing much benefit for two reasons. First, when building the apiclient and the migrations with the musl target, we were clobbering the cache for the gnu target, which then needed to be rebuilt the next time around. Second, in 8f9306c we left it up to cargo to decide which flags to pass to rustc for LTO. It passed `-Clinker-plugin-lto` for apiclient but not for the migrations, so the cache was immediately invalidated and needed to be rebuilt. We solve these problems by using a separate cache directory for the gnu and musl targets, and by specifying the rustc flags we expect. Signed-off-by: Ben Cressey <bcressey@amazon.com>
We spend a significant amount of time compressing debuginfo for limited gain, since the eventual use case for these symbols is to archive them for retrieval from a symbol server. Turning it off improves overall build times. For compressing the RPMs there are two factors at work. Disabling any compression speeds up the build, but the larger artifacts take longer to copy out. Using zstd strikes a reasonable balance between the time to compress and the time to copy. Signed-off-by: Ben Cressey <bcressey@amazon.com>
bcressey
force-pushed
the
fix-rust-build-cache
branch
from
f45cdbf to
c17a8c3
Compare
tjkirch
approved these changes
Aug 17, 2020
webern
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Use a separate cache for gnu and musl targets, so that they don't overwrite each other. Use fixed
rustcflags to avoid lettingcargopick, which can invalidate the musl cache between builds.Disable debuginfo compression since we don't need it. Optimize the compression of the cpio archive inside the rpms for our use case.
Testing done:
While hacking on
growpartI noticed that each build was taking over five minutes which was pretty painful for iterative testing.Changing the Rust macros to better preserve the cache dropped the time to two minutes, while adjusting the compression for debuginfo and cpio archives dropped it to one minute. I verified that all crates are marked as "fresh" in the output for subsequent runs.
Rebuild time when switching variants is now around five minutes.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.