fix growpart to avoid race in partition table reload #1058
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#845
Description of changes:
udevd watches files in /dev via inotify, and when a block disk device is closed after writing, it tells the kernel to reload the partition table.
This was racing with the reload code in growpart; if we were unlucky in our timing, the kernel would be busy with udevd's reload and our call would fail.
To fix this, we stop reloading the partition table in growpart, and use inotify to determine when udevd has deleted and recreated the partition links.
Testing done:
Tested launches and reboots of 250 instances in a cluster. All came up successfully and resized the partition to the expected 20 GiB size.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.