pubsys: grant AMI permissions to target account before copying #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
approved these changes
Aug 24, 2020
webern
approved these changes
Aug 24, 2020
etungsten
approved these changes
Aug 24, 2020
If you specify regional roles in Infra.toml that refer to different accounts,
those accounts need access to the AMI and its snapshots before it can copy
the AMI. This change adds the missing grants:
* If we find an existing AMI, we describe its snapshots so we can grant them
* publish_ami functions were split so we can handle single regions or lists
of regions more easily
* Ask STS for the account IDs of the given roles (removing the original account
ID that already has access)
* modify_snapshots and modify_images were updated with user/group parameters
rather than hardcoding "all"
* A new RegisteredIds struct is used to pass around the image and snapshot IDs
to grant
Co-authored-by: Zac Mrowicki <mrowicki@amazon.com>
Co-authored-by: Tom Kirchner <tjk@amazon.com>
tjkirch
force-pushed
the
copy-permissions
branch
from
644a1e1 to
bd1849b
Compare
|
^ trivial rebase on develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry this looks so long, I don't think it's as bad as it seems; the changes to
publish_ami/mod.rsare basically just splitting methods so we can get/modify snapshots/images individually or in groups, rather than having to construct artificial groups for the single cases.Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.