Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsys: map to EC2 architecture names #1070

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

zmrow
Copy link
Contributor

@zmrow zmrow commented Aug 24, 2020

SSM parameters are used to find EC2 AMI information, so the arch name used in
parameters should match the name used by EC2.

Testing done:

  • Published multiple SSM parameters with all 4 architecture strings to confirm they were mapped correctly
  • Attempted to publish an invalid architecture string to prove it will cause an error

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@zmrow zmrow requested review from tjkirch, bcressey and webern August 24, 2020 16:42
Copy link
Contributor

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💾

@tjkirch tjkirch changed the base branch from ssm-conditional-params to develop August 24, 2020 23:48
SSM parameters are used to find EC2 AMI information, so the arch name used in
parameters should match the name used by EC2.

Co-authored-by: Zac Mrowicki <mrowicki@amazon.com>
Co-authored-by: Tom Kirchner <tjk@amazon.com>
@tjkirch
Copy link
Contributor

tjkirch commented Aug 24, 2020

^ this push is just a trivial rebase on develop.

@tjkirch tjkirch merged commit 7b2b020 into bottlerocket-os:develop Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants