switch to SDK v0.13.0 #1092
Merged
switch to SDK v0.13.0 #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches to the new vendor-specific Rust targets, which fixes some conflicts caused by the confusion between host and target when building for the same architecture (e.g. for x86_64 on x86_64). Signed-off-by: Ben Cressey <bcressey@amazon.com>
Signed-off-by: Ben Cressey <bcressey@amazon.com>
Signed-off-by: Ben Cressey <bcressey@amazon.com>
The support for specifying the number of zstd threads hasn't reached our version of rpm yet, so it was triggering a warning about invalid compression levels. Signed-off-by: Ben Cressey <bcressey@amazon.com>
Otherwise we can't run `grub-bios-setup` when building for the x86_64 architecture on an aarch64 host. We've avoided problems in the opposite case because we create the EFI partition with our own tools for aarch64. Signed-off-by: Ben Cressey <bcressey@amazon.com>
tjkirch
approved these changes
Aug 30, 2020
webern
approved these changes
Aug 31, 2020
iliana
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
This updates to SDK v0.13.0, and includes fixes for building Bottlerocket on a Graviton instance.
The major change is the switch to using our vendor Rust targets, which unblocks the glibc update.
I found the zstd compression warning when inspecting the build logs for grub, which needed a fix to avoid building x86_64 tools on an aarch64 host.
Testing done:
Verified that an x86_64 host could build the OS for both targets, and likewise that an aarch64 host could build the OS for both targets. Verified that the resulting artifacts worked as expected when registered as AMIs.
Note: CI will fail until bottlerocket-os/bottlerocket-sdk/pull/33 is merged and the SDKs are built.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.